Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml editor] make artificial editor lines configurable #1603

Open
rhoehener opened this issue Jun 11, 2024 · 6 comments
Open

[xml editor] make artificial editor lines configurable #1603

rhoehener opened this issue Jun 11, 2024 · 6 comments

Comments

@rhoehener
Copy link

  • these lines often look to me like mistakes until i notice that they are artificial
  • the lines tend to shift after loading:
    • makes the content hard to scan quickly when stepping through file search results
    • causes wrong line to be selected when the lines shift right before the click (I often delete the wrong line with Ctrl + D)

image

@mickaelistria
Copy link
Contributor

The 2nd space between line 1 and 2 is a bug in Platform. Can you please report it to https://github.com/eclipse-platform/eclipse.platform.ui/issues with steps to reproduce?
The question of showing "code minings" annotations/actions or not needs refinement: there are multiple layers on which this could be done: per annotation, per language server, per language, for all editors...

@angelozerr
Copy link
Contributor

@rhoehener if you dont like codelens yiu can disable it for xml with the préférences XML / Code Lens

@rhoehener
Copy link
Author

@angelozerr aah thank you! maybe consider making the options discoverable with an icon next to the line number (like the java editor does for compiler messages):
image

@mickaelistria ok i will (i'm fine with just disabling codelens though, both empty lines disappear)

@rhoehener
Copy link
Author

It appears that the WWD setting also affects the WTP XML editor, so maybe it's still worth investigating from the WWD side as well.

@mickaelistria
Copy link
Contributor

It appears that the WWD setting also affects the WTP XML editor, so maybe it's still worth investigating from the WWD side as well.

In practice, code-minings are enabled for a file-type, not for an editor.

@rhoehener
Copy link
Author

ok, just a bit confusing to me when the setting is in the WWD section and not in the file-type section. after i learned that the WTP XML formatting settings are completely independent from the WWD XML settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants