Is it possible to change product folder name in pomless build of the Mac artifact?

[guw]

I have a Tycho pomless product build. The products are generated without problems. The product definition declares a custom launcher name. This works, i.e. Tycho creates the product for all platforms using the custom launcher name.

The MacOS artifacts are packaged as Eclipse.app app bundles. Is it possible to disable this in a pomless Tycho build or modify the app bundle name to something else?

Also it looks like all other platforms don't use a root folder whereas MacOS artifacts are the only ones using Eclipse.app.

[laeubi]

The MacOS artifacts are packaged as Eclipse.app app bundles. Is it possible to disable this in a pomless Tycho build or modify the app bundle name to something else?

You can use all configuration options in your configurator-pom to customize this e.g.
https://tycho.eclipseprojects.io/doc/latest/tycho-p2-director-plugin/materialize-products-mojo.html

but I think the name of the folders (e.g. Eclipse.app) is required by mac itself (@sratz ?) so it seems not configurable yet. Can you explain what exactly is the desired outcome here, so what specifically should be disabled?

[guw]

I found the explanation for what I am observing:

tycho/tycho-p2-director-plugin/src/main/java/org/eclipse/tycho/plugins/p2/director/Product.java

Lines 105 to 112 in 85e1103

	// bug 461606 - always force folder ending with .app on MacOSX
	if (PlatformPropertiesUtils.OS_MACOSX.equals(os)) {
	if (result == null) {
	result = "Eclipse.app";
	} else if (!result.endsWith(".app")) {
	result = result + ".app";
	}
	}

AFAIK the logic there is correct, i.e. appending .app on MacOS.

A property pom.model.property.rootFolder = foo would be nice but that's a feature request. How do I set the configurator pom? Would that be just the "parent" pom?

[laeubi]

Yes you can configure it in the pluginManagement section of the parent. There you can of course also use a property (that then can be overwritten in build.properties with pom.model.property.myRootFolder = foo this is quite common to use and make pomless more configurable.

[guw]

Thanks Christoph! I'll give that a try.

[guw]

@HannesWell Did you implement the properties injection mentioned in #913 (comment)?

[HannesWell]

Not yet, unfortunately.
But if you have only one *.product file in a folder you can probably inject the properties 'manually' by creating a build.properties file next to the product file and adding corresponding entries like:
pom.model.property.product-id = my-cool-product

For more information see https://github.com/eclipse-tycho/tycho/wiki/Tycho-Pomless#define-properties

[merks]

This is what Oomph does:

https://github.com/eclipse-oomph/oomph/blob/e8303cc893b0f41aa09c0856da89ab03ff4458ee/products/org.eclipse.oomph.setup.installer.product/pom.xml#L367-L373

[jcompagner]

we just use this: buchen/fix-info-plist-maven-plugin: Small Maven plugin to "fix" the Info.plist file generated by p2 during a Tycho product build. <https://github.com/buchen/fix-info-plist-maven-plugin> servoy-eclipse/com.servoy.eclipse.product/pom.xml at master · Servoy/servoy-eclipse <https://github.com/Servoy/servoy-eclipse/blob/master/com.servoy.eclipse.product/pom.xml#L175> that works fine our app is really Servoy.app not Eclipse.app

…

On Thu, 7 Nov 2024 at 16:12, Gunnar Wagenknecht ***@***.***> wrote: I have a Tycho pomless product build. The products are generated without problems. The product definition declares a custom launcher name. This works, i.e. Tycho creates the product for all platforms using the custom launcher name. However, the MacOS artifacts are packaged as Eclipse.app app bundles. Is it possible to disable this in a pomless Tycho build or modify the app bundle name to something else? — Reply to this email directly, view it on GitHub <#4424>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAY7MHDKAZOO2YGTVW2N6DDZ7N7NVAVCNFSM6AAAAABRLN2P7GVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZXGQ2DANZYG4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>