refactor: remove unused findProtocol and findPort functions #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hasanheroglu
commented
Jul 21, 2024
hasanheroglu
commented
- Removed unused findProtocol and findPort functions
- Closes Replacing Protocol and Port Detection #1307
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
|
Those functions are exported and we should NOT remove them. The idea is to remove them once we upgrade the version. Hence I propose to deprecate them again. Note: I am wondering why the CI fails. Are those functions still used? I will re-run the pipeline.. maybe there is another issue... |
This reverts commit fee7c56. Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
danielpeintner
approved these changes
Jul 22, 2024
relu91
approved these changes
Jul 23, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.