Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: delete unused unresolvedInCP param from createResolvedMethodFromJ9Method #20665

Closed
mpirvu opened this issue Nov 21, 2024 · 2 comments · Fixed by #20666
Closed

Cleanup: delete unused unresolvedInCP param from createResolvedMethodFromJ9Method #20665

mpirvu opened this issue Nov 21, 2024 · 2 comments · Fixed by #20666
Assignees
@mpirvu
Labels
comp:jit

Comments

@mpirvu
Copy link
Contributor

mpirvu commented Nov 21, 2024

There are several versions of
createResolvedMethodFromJ9Method(TR::Compilation *comp, I_32 cpIndex, uint32_t vTableSlot, J9Method *j9Method, bool * unresolvedInCP, TR_AOTInliningStats *aotStats)
The parameter unresolvedInCP is not used in any of them, so it can be deleted.
@github-actions GitHub Actions
Copy link

Issue Number: 20665
Status: Open
Recommended Components: comp:vm, comp:gc, comp:test

@mpirvu mpirvu self-assigned this Nov 21, 2024
mpirvu added a commit to mpirvu/openj9 that referenced this issue Nov 21, 2024
@mpirvu
Remove unresolvedInCP param from createResolvedMethodFromJ9Method
4d4dc53 
This parameter is unused and can be safely removed.

Fixes: eclipse-openj9#20665

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@mpirvu mpirvu mentioned this issue Nov 21, 2024
Merged
mpirvu added a commit to mpirvu/openj9 that referenced this issue Nov 23, 2024
@mpirvu
Remove unresolvedInCP param from createResolvedMethodFromJ9Method
0c05105 
This parameter is unused and can be safely removed.

Fixes: eclipse-openj9#20665

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@github-actions GitHub Actions
Copy link

Issue Number: 20665
Status: Closed
Actual Components: comp:jit
Actual Assignees: No one :(
PR Assignees: mpirvu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpirvu mpirvu

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unresolvedInCP param from createResolvedMethodFromJ9Method mpirvu/openj9
1 participant
@mpirvu