Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nightingale tooltip #289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justintyf01
Copy link

I am using this nightingale library for antibody sequence visualisation and it was missing a tooltip component. I have implemented this component, feel free to use it if deemed useful.

  • Edited Feature type to include "description" and "evidence" instead of "tooltipContent".
  • Main CSS styling for tooltip is in nightingale-tooltip
  • Implemented a handleTrackClick in nightingale-manager that is called by the existing "change" event listener when a track is clicked
  • Implemented new document event listener to handle closing of tooltip and de-highlighting when user clicks elsewhere on the screen

Thank you.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for cozy-marzipan-abb3b4 ready!

Name Link
🔨 Latest commit dbb93d3
🔍 Latest deploy log https://app.netlify.com/sites/cozy-marzipan-abb3b4/deploys/668cf6576fcdb70008af5d23
😎 Deploy Preview https://deploy-preview-289--cozy-marzipan-abb3b4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gustavo-salazar
Copy link
Contributor

Dear @justintyf01
Thank you so much for opening this PR, and sorry for taking this long to reply.
And yeah, a tooltip is something other users have requested. So, I'll happily include a component that offers that into Nightingale.
I will check this PR soon but I'll ask you 2 things before:

  1. The formatting on your side uses 4 spaces, and maybe other options that are making the read of your changes a harder than needed. I have run npm run format on main, so please do the same on your branch, after merging the latest changes from main. Hopefully. this will make the PR to only show the important changes.
  2. Please create a story in /stories so we can see an example of the tooltip in the demo app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants