Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog series expanded #612

Merged
merged 14 commits into from
Aug 15, 2023
Merged

Conversation

avinder-red-crackle
Copy link
Contributor

No description provided.

@thtmnisamnstr thtmnisamnstr linked an issue Aug 11, 2023 that may be closed by this pull request
@thtmnisamnstr
Copy link
Contributor

On desktop, move the "Blog / Series / [Series Name]" header to the right above the Series box.
image

On mobile, can you add a drawer below the Series drawer with the table of contents.
image

@avinder-red-crackle
Copy link
Contributor Author

Preview URL: https://64da01b0c63d74277dac64b1--ephemeral-narwhal-3ac3b2.netlify.app

What if there is no series box like in this? Where should the breadcrumbs appear?

@adamgordonbell
Copy link
Contributor

What if there is no series box like in this? Where should the breadcrumbs appear?

If there's no series box nothing should change.

Can we revert the table of contents to how it was for now:

Screenshot 2023-08-14 at 8 11 58 AM

This bread crumb needs to link to the correct series page:
Screenshot 2023-08-14 at 8 12 32 AM

For instance:
https://64da01b0c63d74277dac64b1--ephemeral-narwhal-3ac3b2.netlify.app/blog/series/makefile/

Can we not have the series box be sticky, so it doesn't overlap like this:
Screenshot 2023-08-14 at 8 15 33 AM
Same for the bread crumbs:
Screenshot 2023-08-14 at 8 16 36 AM

Example:
https://64da01b0c63d74277dac64b1--ephemeral-narwhal-3ac3b2.netlify.app/blog/printf-debugging/

@adamgordonbell adamgordonbell self-requested a review August 14, 2023 12:18
@avinder-red-crackle
Copy link
Contributor Author

@adamgordonbell adamgordonbell merged commit b95e915 into earthly:main Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog: Series on Right Hand Side Expanded
3 participants