-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
component status alignment #2026
Comments
@agliga, I updated the issue description with the approach we discussed earlier today. I'll work on changes to the JSON file and put up the PR. I'll also get you the appropriate playbook URL prefix to add to the script, and then you can start on script updates. Looking forward to working with you on this! Excited that the Playbook page and readmes will dynamically link to each other. |
@agliga @cordeliadillon, shouldn't the skin module be the primary entry point for determining the version of the Design System (DS) being used? The script should verify the existence of a component rather than checking which DS version is implemented, as the version is already specified by the skin module (see example). My point is that the JavaScript libraries (ebayui-core and ui-core-react) shouldn't need to maintain a JSON file with DS version links, as this information is already managed by the skin module. The skin module defines the DS version, while the JS libraries handle behavior, not styling. I understand that there may be cases where variants are missing or not fully compatible with the DS version implemented by the skin. However, maintaining these JSON files over time is a significant burden and may not always be accurate. Additionally, these JSON files can become outdated or incorrect. |
Introduce additional metadata in the ds-versions.json file to help us programmatically link ebayui-core component to the Design System components/patterns they implement.
Proposed changes to DS versions JSON
Instead of a 1:1 mapping of ebayui-core component name to version, map ebayui-core component name to an object containing multiple pieces of metadata about its design system relationship:
name
string
version
string
|number
status
string
If a component maps to multiple Design System components, map it to an array of metadata.
For example:
Proposed changes to DS versions script
This script pulls component-specific metadata from the
ds-versions.json
file and prepends it to the component's readme.Proposed process changes
ds-versions.json
is up-to-dateThe text was updated successfully, but these errors were encountered: