Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactory / allow other settings libraries than pydantic_settings #9

Merged
merged 5 commits into from
Nov 22, 2024
Merged

refactory / allow other settings libraries than pydantic_settings #9

merged 5 commits into from
Nov 22, 2024

Conversation

devkral
Copy link
Collaborator

@devkral devkral commented Nov 21, 2024

Changes:

  • remove hard settings dependency to pydantic_settings
  • refactor internals
  • fix docs, they look nicer now (if they would build)

@devkral
Changes:
a22400a 
- split base.py
- don't require settings being a pydantic settings object
- add get_value_from_settings helper for handling attribute based
  settings as well dictionaries
- bump version
@devkral
Changes:
524f3aa 
- apply basic styling
- fix docs
@devkral
Changes:
bfd0669 
- fix ruff integration
- reformat files
@devkral devkral requested a review from tarsil November 21, 2024 10:26
@devkral
Copy link
Collaborator Author

devkral commented Nov 21, 2024 •
edited
Loading

I was a bit faster than you with the docs ;)

@devkral devkral mentioned this pull request Nov 22, 2024
Merged
@devkral devkral merged commit 6f3fbc1 into main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil