Model(null=False) not working properly in migration

[rorik302]

I have model

class Tenant(edgy.Model):
    class Meta:
        tablename = "tenants"
        registry = registry

    id: UUID = UUIDField(primary_key=True, default=str(uuid4()))
    created_at: datetime = DateTimeField(auto_now_add=True)
    updated_at: datetime = DateTimeField(auto_now=True)
    is_active: bool = BooleanField(default=True)
    schema_name: str = CharField(max_length=100, default=generate_tenant_schema_name)

When I call alembic revision command I have following upgrade code

def upgrade() -> None:
    # ### commands auto generated by Alembic - please adjust! ###
    op.create_table('tenants',
    sa.Column('id', sa.UUID(), nullable=False),
    sa.Column('created_at', sa.DateTime(), nullable=True),
    sa.Column('updated_at', sa.DateTime(), nullable=True),
    sa.Column('is_active', sa.Boolean(), nullable=True),
    sa.Column('schema_name', sa.String(length=100), nullable=True),
    sa.PrimaryKeyConstraint('id'),
    schema='shared'
    )
    # ### end Alembic commands ###

Although Edgy use null=False by default in the FieldFactory object

P.S. I use custom alembic config, not Edgy

[tarsil]

@rorik302 this is because every time there is a default provided or a server_default is provided, the nullable is true because of that same default.

Does this make sense to you? In the case of date times, it will automatically generate the dates on save, for instance.

[rorik302]

I have another model

class User(BaseModel):
    class Meta(SharedMeta):
        tablename = "users"
        registry = shared_registry

    email: str = CharField(max_length=100, unique=True)
    password: str = CharField(max_length=100)
    tenant: Tenant = ForeignKey(Tenant, on_delete="CASCADE")

tenant has no default, but alembic set sa.Column('tenant', sa.UUID(), nullable=True)
email and password set right sa.Column('email', sa.String(length=100), nullable=False), sa.Column('password', sa.String(length=100), nullable=False)

[tarsil]

I have another model

class User(BaseModel):
    class Meta(SharedMeta):
        tablename = "users"
        registry = shared_registry

    email: str = CharField(max_length=100, unique=True)
    password: str = CharField(max_length=100)
    tenant: Tenant = ForeignKey(Tenant, on_delete="CASCADE")

tenant has no default, but alembic set sa.Column('tenant', sa.UUID(), nullable=True) email and password set right sa.Column('email', sa.String(length=100), nullable=False), sa.Column('password', sa.String(length=100), nullable=False)

I'm trying to run a general validation that is also related with the other discussion you opened. If you checkout fix/primary_keys and give it a try, I think now it should show the right values for the nullable and at the same time fix the issue from here #46.

This is why I haven't merge it yet as it would be nice if you could test it before.

[rorik302]

Yes, tenant is nullable=False now

[tarsil]

Is the server default also ok? If yes I will merge and today a new release will be done 🙂

[rorik302]

Yes, server_default also work

[tarsil]

Release 0.6.0 is now deployed 👍🏼 thank you for your help @rorik302