diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1276cb2c3..00f4e2d4a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -25,6 +25,23 @@ I have... - [ ] All CI checks have passed - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code) +SDK Checklist +- [ ] Import/Export Genesis +- [ ] Registered Invariants +- [ ] Registered Events +- [ ] Updated openapi.yaml +- [ ] No usage of go `map` +- [ ] No usage of `time.Now()` +- [ ] Used fixed point arithmetic and not float arithmetic +- [ ] Avoid panicking in Begin/End block as much as possible +- [ ] No unexpeted math Overflow +- [ ] Used `sendCoin` and not `SendCoins` +- [ ] Out-of-block compute is bounded +- [ ] No serialized ID at the end of store keys + +Full security checklist [here](https://www.faulttolerant.xyz/2024-01-16-cosmos-security-1/) + + --- For Reviewer: