Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: Include min gas price in rollapp consensus params #497

Open
omritoptix opened this issue Aug 5, 2024 · 5 comments
Open

params: Include min gas price in rollapp consensus params #497

omritoptix opened this issue Aug 5, 2024 · 5 comments
Assignees
Labels

Comments

@omritoptix
Copy link
Contributor

related research: https://www.notion.so/dymension/ADR-x-Rollapp-Consensus-Params-d60daee1f8cb42e38e43e1ef5289a220#7bc260fefb05421d9d407727cf82cea5

@danwt
Copy link
Contributor

danwt commented Aug 6, 2024

Quoting @omritoptix from notion

Charge more gas than ‘normal’
I believe a mitigation would be to store the gas-price as an on-chain param.

In case the sequencer decides to manipulate it (e.g increase), the relevant transaction hash can be sent to the hub as an evidence. The tx query should provide I believe with the reason for failure and maybe validator can query it using vote extension.

e.g

Error: insufficient fees; got: 100uatom required: 250uatom

Given you can also get the gas units ( "gas_wanted": "200000",
"gas_used": "50132”) you can deduce the price that was passed.

the endpoint: curl -X GET "http://localhost:1317/cosmos/tx/v1beta1/txs/{tx_hash}"

@omritoptix omritoptix assigned srene and unassigned spoo-bar Aug 19, 2024
@danwt
Copy link
Contributor

danwt commented Aug 21, 2024

@srene is this one already tackled by the recent consensus params PRs?

@danwt
Copy link
Contributor

danwt commented Aug 22, 2024

@omritoptix is this one in V3? I think I read somewhere it will be after?

@danwt danwt added the security label Aug 22, 2024
@danwt danwt changed the title Include min gas price in rollapp consensus params params: Include min gas price in rollapp consensus params Aug 22, 2024
@srene
Copy link
Contributor

srene commented Aug 23, 2024

@dawnt gas-price is not yet included in the current dymint PR

@omritoptix
Copy link
Contributor Author

not gonna happen in 3D I blv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants