Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryRef missing from core/src/lib/index.ts #4

Open
Honga1 opened this issue Sep 2, 2021 · 2 comments
Open

QueryRef missing from core/src/lib/index.ts #4

Honga1 opened this issue Sep 2, 2021 · 2 comments

Comments

@Honga1
Copy link
Contributor

Honga1 commented Sep 2, 2021

What

It seems like QueryRef is missing from https://github.com/dustinlacewell/react-ecs/blob/master/libs/core/src/lib/index.ts

Thus I cannot include it from the built javascript files.

Why it's needed

I found perhaps another related issue with useQuery. It does not disconnect queries on the unmount of the hosting component. In a fix I made for this issue I needed access to the QueryRef constructor. Should this related issue I'll create another ticket for this error with a repro.

@dustinlacewell
Copy link
Owner

Great. I'm ramping up for a new job, so any help you can provide with PRs, I'll be happy to review.

dustinlacewell pushed a commit that referenced this issue Dec 11, 2021
@bvkimball
Copy link
Contributor

Any chance we can get the latest published to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants