-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude description sections of automations.yaml (entities noted in comment sections) #71
Comments
Plus (more improvement to reduce false positives):
|
This part is pretty much same as #56 |
You're right. So ignore that additional post for now and let's focus on the original one. At the same time both share the same target - getting rid of unnecessary false positives. |
Meanwhile I discovered that the integration alreay ignores certain entities, usually when there's a Unfortunately, that's not enough for the basic issue, as comment sections spread over a certain amount of text. But maybe this "comment section detection" can be extended to also address and solve this issue. |
In version 0.6.4 single-line Supporting multiline descriptions in parsing requires significant changes, we might address this later. |
I really like the recent work you are putting in this integration. Looking forward to see the improvement running 0.6.4. Any estimations when it will be released? |
Thanks for the kind words! It's almost ready, just polishing minor details and running some real-world tests before publishing. There were a lot of changes and refactoring under the hood, so I expect there may be some bugs not covered by the unit tests. Hopefully, this will make future development easier. |
Problem: Currently Watchman also finds and lists entities which are used in the comment sections of automations. This triggers false positives - and makes (based on the intensity of individual documentation/commenting) using this basically absolutely great integration a bit useless. 😞
Feature Request: Ignore all entites from the
description:
sections of automations.yamlExample:
Actual automations.yaml snippet:
This should remove false positives massively. Looking at some (former) issues and reports, plenty of those findings for others too.
Manually setting those entities on the ignore list is only workaround - if at all.
The text was updated successfully, but these errors were encountered: