You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Snooze works great, thanks for your work. I did hit a small issue when using a Teensy LC, and trying to use INPUT_PULLDOWN for waking with SnoozeDigital (for waking when a signal goes high, basically the inverse of button_hold_wakeup).
The other HALs implement INPUT, INPUT_PULLUP, and INPUT_PULLDOWN:
After I modified line 88 to match the other HALs, waking seemed to work fine. So it seems like an omission, especially given the else if on line 94. I also looked in the datasheet and didn't find anything that would indicate INPUT_PULLDOWN is different in any way? If there's a a reason INPUT_PULLDOWN really isn't supported, it would be good to document that. In either case, I can cut a PR if you'd like.
The text was updated successfully, but these errors were encountered:
Snooze works great, thanks for your work. I did hit a small issue when using a Teensy LC, and trying to use
INPUT_PULLDOWN
for waking withSnoozeDigital
(for waking when a signal goes high, basically the inverse of button_hold_wakeup).The other HALs implement
INPUT
,INPUT_PULLUP
, andINPUT_PULLDOWN
:Snooze/src/hal/TEENSY_32/SnoozeDigital.cpp
Lines 121 to 128 in 4ae33c6
Snooze/src/hal/TEENSY_35/SnoozeDigital.cpp
Lines 115 to 122 in 4ae33c6
Snooze/src/hal/TEENSY_36/SnoozeDigital.cpp
Lines 121 to 128 in 4ae33c6
It looks like
INPUT_PULLDOWN
was intended to work with the Teensy LC?Snooze/src/hal/TEENSY_LC/SnoozeDigital.cpp
Lines 88 to 97 in 4ae33c6
After I modified line 88 to match the other HALs, waking seemed to work fine. So it seems like an omission, especially given the
else if
on line 94. I also looked in the datasheet and didn't find anything that would indicateINPUT_PULLDOWN
is different in any way? If there's a a reasonINPUT_PULLDOWN
really isn't supported, it would be good to document that. In either case, I can cut a PR if you'd like.The text was updated successfully, but these errors were encountered: