feat: Implement error emission about existing file (#1076)

**Related issue:** - Part of #705
dudykr · Sep 10, 2023 · 90f7c04 · 90f7c04
1 parent 637a99c
commit 90f7c04
Show file tree

Hide file tree

Showing 16 changed files with 105 additions and 23 deletions.
diff --git a/crates/stc_ts_type_checker/tests/conformance.pass.txt b/crates/stc_ts_type_checker/tests/conformance.pass.txt
@@ -1699,6 +1699,7 @@ externalModules/multipleExportDefault6.ts
 externalModules/nameDelimitedBySlashes.ts
 externalModules/nameWithFileExtension.ts
 externalModules/reexportClassDefinition.ts
+externalModules/relativePathMustResolve.ts
 externalModules/topLevelAwait.3.ts
 externalModules/topLevelFileModule.ts
 externalModules/topLevelFileModuleMissing.ts

diff --git a/..._checker/tests/conformance/externalModules/moduleResolutionWithExtensions.error-diff.json b/..._checker/tests/conformance/externalModules/moduleResolutionWithExtensions.error-diff.json
@@ -0,0 +1,12 @@
+{
+  "required_errors": {},
+  "required_error_lines": {},
+  "extra_errors": {
+    "TS2307": 1
+  },
+  "extra_error_lines": {
+    "TS2307": [
+      1
+    ]
+  }
+}
diff --git a/...checker/tests/conformance/externalModules/moduleResolutionWithExtensions.stats.rust-debug b/...checker/tests/conformance/externalModules/moduleResolutionWithExtensions.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
     required_error: 0,
     matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    extra_error: 1,
+    panic: 0,
 }
diff --git a/...s_type_checker/tests/conformance/externalModules/relativePathMustResolve.stats.rust-debug b/...s_type_checker/tests/conformance/externalModules/relativePathMustResolve.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
-    required_error: 1,
-    matched_error: 0,
+    required_error: 0,
+    matched_error: 1,
     extra_error: 0,
-    panic: 1,
+    panic: 0,
 }
diff --git a/...e_checker/tests/conformance/externalModules/relativePathToDeclarationFile.error-diff.json b/...e_checker/tests/conformance/externalModules/relativePathToDeclarationFile.error-diff.json
@@ -0,0 +1,14 @@
+{
+  "required_errors": {},
+  "required_error_lines": {},
+  "extra_errors": {
+    "TS2307": 3
+  },
+  "extra_error_lines": {
+    "TS2307": [
+      1,
+      2,
+      3
+    ]
+  }
+}
diff --git a/..._checker/tests/conformance/externalModules/relativePathToDeclarationFile.stats.rust-debug b/..._checker/tests/conformance/externalModules/relativePathToDeclarationFile.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
     required_error: 0,
     matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    extra_error: 3,
+    panic: 0,
 }
diff --git a/...ype_checker/tests/conformance/moduleResolution/allowImportingTsExtensions.error-diff.json b/...ype_checker/tests/conformance/moduleResolution/allowImportingTsExtensions.error-diff.json
@@ -0,0 +1,12 @@
+{
+  "required_errors": {},
+  "required_error_lines": {},
+  "extra_errors": {
+    "TS2307": 1
+  },
+  "extra_error_lines": {
+    "TS2307": [
+      1
+    ]
+  }
+}
diff --git a/...pe_checker/tests/conformance/moduleResolution/allowImportingTsExtensions.stats.rust-debug b/...pe_checker/tests/conformance/moduleResolution/allowImportingTsExtensions.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
     required_error: 0,
     matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    extra_error: 1,
+    panic: 0,
 }
diff --git a/...nformance/nonjsExtensions/declarationFileForHtmlFileWithinDeclarationFile.error-diff.json b/...nformance/nonjsExtensions/declarationFileForHtmlFileWithinDeclarationFile.error-diff.json
@@ -0,0 +1,13 @@
+{
+  "required_errors": {},
+  "required_error_lines": {},
+  "extra_errors": {
+    "TS2307": 2
+  },
+  "extra_error_lines": {
+    "TS2307": [
+      1,
+      1
+    ]
+  }
+}
diff --git a/...formance/nonjsExtensions/declarationFileForHtmlFileWithinDeclarationFile.stats.rust-debug b/...formance/nonjsExtensions/declarationFileForHtmlFileWithinDeclarationFile.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
     required_error: 0,
     matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    extra_error: 2,
+    panic: 0,
 }
diff --git a/...pe_checker/tests/conformance/nonjsExtensions/declarationFileForHtmlImport.error-diff.json b/...pe_checker/tests/conformance/nonjsExtensions/declarationFileForHtmlImport.error-diff.json
@@ -0,0 +1,12 @@
+{
+  "required_errors": {},
+  "required_error_lines": {},
+  "extra_errors": {
+    "TS2307": 1
+  },
+  "extra_error_lines": {
+    "TS2307": [
+      1
+    ]
+  }
+}
diff --git a/...e_checker/tests/conformance/nonjsExtensions/declarationFileForHtmlImport.stats.rust-debug b/...e_checker/tests/conformance/nonjsExtensions/declarationFileForHtmlImport.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
     required_error: 0,
     matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    extra_error: 1,
+    panic: 0,
 }
diff --git a/...stc_ts_type_checker/tests/conformance/types/import/importTypeLocalMissing.error-diff.json b/...stc_ts_type_checker/tests/conformance/types/import/importTypeLocalMissing.error-diff.json
@@ -0,0 +1,18 @@
+{
+  "required_errors": {
+    "TS2694": 1
+  },
+  "required_error_lines": {
+    "TS2694": [
+      3
+    ]
+  },
+  "extra_errors": {
+    "TS0": 1
+  },
+  "extra_error_lines": {
+    "TS0": [
+      16
+    ]
+  }
+}
diff --git a/...tc_ts_type_checker/tests/conformance/types/import/importTypeLocalMissing.stats.rust-debug b/...tc_ts_type_checker/tests/conformance/types/import/importTypeLocalMissing.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
-    required_error: 4,
-    matched_error: 0,
-    extra_error: 0,
-    panic: 1,
+    required_error: 1,
+    matched_error: 3,
+    extra_error: 1,
+    panic: 0,
 }
diff --git a/crates/stc_ts_type_checker/tests/tsc-stats.rust-debug b/crates/stc_ts_type_checker/tests/tsc-stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
-    required_error: 3493,
-    matched_error: 6542,
-    extra_error: 764,
-    panic: 73,
+    required_error: 3489,
+    matched_error: 6546,
+    extra_error: 773,
+    panic: 66,
 }
diff --git a/crates/stc_ts_type_checker/tests/tsc.rs b/crates/stc_ts_type_checker/tests/tsc.rs
@@ -16,7 +16,7 @@ use std::{
     sync::Arc,
 };
 
-use anyhow::{Context, Error};
+use anyhow::{bail, Context, Error};
 use indexmap::IndexMap;
 use once_cell::sync::Lazy;
 use parking_lot::Mutex;
@@ -662,7 +662,7 @@ impl LoadFile for TestFileSystem {
             }
         }
 
-        todo!("load_file: {:?} ", filename);
+        bail!("not found module");
     }
 }