Add a configurable option for importing CompareImages #471
Labels
alert: NEED ACCOUNT KEY
Need to assign an account key to this issue
alert: NEED CYCLE ASSIGNMENT
Need to assign to a release development cycle
component: external dependency
External dependency issue
component: testing
Software testing issue
priority: high
High Priority
requestor: METplus Team
METplus Development Team
type: enhancement
Improve something that it is currently doing
Milestone
Describe the Enhancement
When running test/run_all_nco.sh or test/pythest on WCOSS2, the code errors out with:
These failures were not present in the beta5 installation, and 'imutils' is not allowed on WCOSS2.
It appears this situation came about from this PR Feature 461 make compare images configurable #467 where the line "from metcalcpy.compare_images import CompareImages" was uncommented from approximately 20 files. CompareImages in METcalcpy imports 'imutils'. It looks like the PR intended to make the use of CompareImages configurable by an environment variable used in conftest.py. But, conftest.py is not what is used to test on WCOSS2, instead run_all_nco.sh is used. However, when running pytest the 'imutils' errors are still present.
The code was commented out again in this PR 461 revert compare images changes #472.
We need a configurable option so that the CompareImages isn't imported on WCOSS2, but could be elsewhere if desired.
Time Estimate
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
None
Funding Source
Define the Metadata
Assignee
Labels
Milestone and Projects###
Define Related Issue(s)##
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
Branch name:
bugfix_<Issue Number>_main_<Version>_<Description>
Pull request:
bugfix <Issue Number> main_<Version> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next bugfix version
Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
Branch name:
bugfix_<Issue Number>_develop_<Description>
Pull request:
bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METplotpy-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: