From 4cfbdbad363bdd62ea3fa75a0c00c0f5825f2e0d Mon Sep 17 00:00:00 2001 From: Ian McGinnis <67600557+ian-noaa@users.noreply.github.com> Date: Fri, 4 Aug 2023 20:50:55 -0600 Subject: [PATCH] Deactivate image scanning for now Our images have exploded in size for some reason. For now, try deactivating image scanning in the hopes that some images build. Additionally, deactivate fail-fast to see if we can get more images built. --- .github/workflows/build.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c9d4213a..0f1f0ce26 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,7 +44,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 120 strategy: - fail-fast: true + # fail-fast: true # FIXME: Reactivate fail-fast once our image size is under control matrix: app: - met-airquality @@ -105,19 +105,19 @@ jobs: --build-arg COMMITSHA=${{ github.sha }} \ -t ${{ env.DEV_REGISTRY }}/${{ env.APP_LOWERCASE }}:${{ env.BRANCH }} \ . + # FIXME: Reactivate image scanning once we've determined why the image size has blown up + # - name: Scan image with Trivy + # uses: aquasecurity/trivy-action@master + # with: + # image-ref: '${{ env.DEV_REGISTRY }}/${{ env.APP_LOWERCASE }}:${{ env.BRANCH }}' + # format: 'sarif' + # output: 'trivy-results-${{ env.APP_LOWERCASE }}.sarif' + # ignore-unfixed: true - - name: Scan image with Trivy - uses: aquasecurity/trivy-action@master - with: - image-ref: '${{ env.DEV_REGISTRY }}/${{ env.APP_LOWERCASE }}:${{ env.BRANCH }}' - format: 'sarif' - output: 'trivy-results-${{ env.APP_LOWERCASE }}.sarif' - ignore-unfixed: true - - - name: Upload Trivy scan results to GitHub Security tab - uses: github/codeql-action/upload-sarif@v2 - with: - sarif_file: 'trivy-results-${{ env.APP_LOWERCASE }}.sarif' + # - name: Upload Trivy scan results to GitHub Security tab + # uses: github/codeql-action/upload-sarif@v2 + # with: + # sarif_file: 'trivy-results-${{ env.APP_LOWERCASE }}.sarif' - name: Login to GitHub Container Registry uses: docker/login-action@v1