Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor blocking and weather regime code so they are more flexible #392

Open
23 tasks
CPKalb opened this issue Jun 28, 2024 · 0 comments
Open
23 tasks

Refactor blocking and weather regime code so they are more flexible #392

CPKalb opened this issue Jun 28, 2024 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: enhancement Improve something that it is currently doing

Comments

@CPKalb
Copy link
Contributor

CPKalb commented Jun 28, 2024

Describe the Enhancement

The blocking and weather regime code currently require input that has the same number of days for each year. So, if someone is verifying DJF for 10 years, each year would need to have 90 days of data (leap years omitted). The driver script in METplus will fill missing data, but the user must enter start and end dates to include 90 days of each year (20001201 - 20200228 would work, whereas 20001201 - 20200101 would not). The code came to us this way, but it should be made more flexible. Making it more flexible will allow to remove some variables needed in the blocking and weather regime use cases

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METcalcpy-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METcalcpy-X.Y.Z version, select the METcalcpy-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METcalcpy-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@CPKalb CPKalb added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant