fix: C++/CLI mixed mode cannot be used as reference assemblies #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscom crashes, when a C++/CLI Mixed mode assembly is used as a reference. This is due to the fact, that dotnet cannot load C++/CLI mixed moded assemblies into a collectible AssemblyLoadContext. Closes #292 For details refer to dotnet/runtime#72237
|
I like this solution, thanks for this PR. If possible would be fantastic to have an unit test to ensure full compatibility in future with C++/CLI assemblies. |
added 3 commits
November 19, 2024 15:06
TLB embedding requires the assemblies to be unloaded before the embedding process starts. An AssemblyLoadContext cannot load C++/CLI assemblies, if it shall be collectible.
dotnet format once more
|
@electro-logic I am currently stuck in a meeting, but come back to this in the course of the day. If you are ok with this, I will take the "BugDemo.zip" you provided us with and add it as an acceptance / end to end test. |
|
@carstencodes it's completely fine, thanks |
|
#299 is on its way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dscom crashes, when a C++/CLI Mixed mode assembly is used as a reference.
This is due to the fact, that dotnet cannot load C++/CLI mixed moded assemblies into a collectible AssemblyLoadContext.
Closes #292
For details refer to dotnet/runtime#72237