Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to use emotion #571

Open
2 of 4 tasks
micleners opened this issue Oct 16, 2019 · 1 comment
Open
2 of 4 tasks

Update styles to use emotion #571

micleners opened this issue Oct 16, 2019 · 1 comment

Comments

@micleners
Copy link
Member

micleners commented Oct 16, 2019

Main Objective: replace all use cases of glamorous and glamor to use emotion object styles

Purpose:

  • Unify styling under pattern
  • Scope styles to components
  • Implement object based syntax rather than template literal approach

Several different implementations currently exist for styling components, however each finished implementation should follow the same pattern. Here are two patterns that could be followed for final implementation:

Examples of implementations that need to be changed over to emotion:

Recommendations:

  • Use storybook to confirm styling doesn't change from before to after your fix implementation
  • Changing one file per commit per PR
  • Use git cz commit type of fix so there is a version bump associated with a successfully merged PR (if you need help setting up commitizen visit this link)

Feel free to reach out with questions or bring the conversation to the DSM Web Collective Slack

  • migrate style prop usage
  • migrate direct usage of glamor
  • migrate glamourous usage
  • remove packages
travi added a commit that referenced this issue Oct 27, 2019
which removes the need to depend on glamor

for #571
micleners added a commit to micleners/components that referenced this issue Nov 13, 2019
Remove Div from glamorous and replace with regular div in config.cs

re dsmjs#571
micleners added a commit to micleners/components that referenced this issue Nov 14, 2019
Replaced styled components with style objects. Applied styles with css prop.

re dsmjs#571
micleners added a commit to micleners/components that referenced this issue Nov 14, 2019
Replaced styled components with style objects. Applied styles with css prop.

re dsmjs#571
micleners added a commit to micleners/components that referenced this issue Nov 14, 2019
Removed Div and replaced with regular div

re dsmjs#571
@travi
Copy link
Member

travi commented Jun 16, 2020

been a while since i've looked back at this stuff. do you remember off the top of your head if we completed the final cleanup of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants