-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles to use emotion
#571
Comments
travi
added a commit
that referenced
this issue
Oct 27, 2019
which removes the need to depend on glamor for #571
micleners
added a commit
to micleners/components
that referenced
this issue
Nov 13, 2019
Remove Div from glamorous and replace with regular div in config.cs re dsmjs#571
micleners
added a commit
to micleners/components
that referenced
this issue
Nov 14, 2019
Replaced styled components with style objects. Applied styles with css prop. re dsmjs#571
micleners
added a commit
to micleners/components
that referenced
this issue
Nov 14, 2019
Replaced styled components with style objects. Applied styles with css prop. re dsmjs#571
micleners
added a commit
to micleners/components
that referenced
this issue
Nov 14, 2019
Removed Div and replaced with regular div re dsmjs#571
been a while since i've looked back at this stuff. do you remember off the top of your head if we completed the final cleanup of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Main Objective: replace all use cases of
glamorous
andglamor
to useemotion
object stylesPurpose:
Several different implementations currently exist for styling
components
, however each finished implementation should follow the same pattern. Here are two patterns that could be followed for final implementation:css
implementation: copyright atomcss
implementation: talk moleculeExamples of implementations that need to be changed over to emotion:
glamor
dependence`: navigation atomglamorous
dependence: sponsor bar atomRecommendations:
git cz
commit type offix
so there is a version bump associated with a successfully merged PR (if you need help setting upcommitizen
visit this link)Feel free to reach out with questions or bring the conversation to the DSM Web Collective Slack
style
prop usageglamor
glamourous
usageThe text was updated successfully, but these errors were encountered: