Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a release #17

Open
Chris2011 opened this issue Jul 7, 2017 · 16 comments
Open

Please make a release #17

Chris2011 opened this issue Jul 7, 2017 · 16 comments

Comments

@Chris2011
Copy link

It would be great, if we can have a pre-build nbm file here and if it is still usable and releasable please upload it to the plugin portal of NetBeans.

Regards

Chris

@Chris2011 Chris2011 changed the title Please make a releaseb Please make a release Jul 7, 2017
@drrb
Copy link
Owner

drrb commented Sep 28, 2017

Working on it! I'm currently updating it to work with newest Rust and NetBeans versions.

@Chris2011
Copy link
Author

Only to ask, I wanted to build the plugin and it needs ruby, is there a specific reason why? Thx.

@drrb
Copy link
Owner

drrb commented Sep 30, 2017

Yes, it's for generating sources while I'm updating the Rust parser. I'll probably remove it once the parser is more stable. Meanwhile, you should be able to build it without Ruby like this:

$ mvn package -Dexec.skip -DskipTests

Don't expect too much at the moment. The parser is about 1/3 complete, so you'll probably see exceptions in the UI.

@Chris2011
Copy link
Author

No problem. Thx :) Will test it later.

@Chris2011
Copy link
Author

I can't install the plugin, because of this error:

image

@drrb
Copy link
Owner

drrb commented Oct 1, 2017

We're currently depending on a pretty old implementation version of the Common Test Runner API that came with NetBeans 8.0.x. From memory, the Common Test Runner API required pinning to a specific implementation version so that we could access the API. I'll take another look into it when I update the plugin for more recent NetBeans versions. Opened #18 to track the CTR API issue, and #19 to track porting to newer versions of NetBeans.

@Chris2011
Copy link
Author

Great, thx :) Would be cool to test it soon. I know that there is not that much inside but, a bit is better than nothing.

@drrb
Copy link
Owner

drrb commented Oct 7, 2017

There's a NetBeans 8.2 branch now (https://github.com/drrb/rust-netbeans/tree/netbeans-8.2). One test is still having problems, but you should be able to build that branch for use with NetBeans 8.2.

@Chris2011
Copy link
Author

Great thx :)

@Chris2011
Copy link
Author

Great it works :) Should I create more tickets for that what is not working now or should I wait?

@drrb
Copy link
Owner

drrb commented Oct 8, 2017

Good to hear. You're welcome to create tickets if you like. For things like the parser where there's a lot missing, please keep tickets high-level (e.g. "Some language features not supported by parser", rather than, e.g. "Impls in source files don't work"). I'm happy for you create pull requests too.

@Chris2011
Copy link
Author

Because of the broken parser, did you created the javacc grammar file, by your own? Maybe antlr can do it better? See this grammar, maybe it will help: https://github.com/jbclements/rust-antlr

Kind of old, but maybe better. Only guessing. I know then you have to switch to ANTLR, I did this for my C# plugin for NetBeans too. Because there was no javacc grammar file for C#.

@drrb
Copy link
Owner

drrb commented Oct 14, 2017

Yes, the grammar is still in progress, because I'm writing it myself. I initially did use jbclements/rust-antlr (in 2013), and then switched to using the native parser from rustc, and now to building a JavaCC parser myself. It's partly because the rust-antlr is quite old and slow to parse large documents, and partly because I'm interested in writing the parser myself to learn. My plan is to gradually support all of Rust using the JavaCC parser.

@Chris2011
Copy link
Author

ok, thx for the info :)

@Chris2011
Copy link
Author

Hi, what is still missing to make a first alpha release? I will check back the plugin again. Are you still working on it?

@Chris2011
Copy link
Author

I would like to catch this project up again, it get's more interesting for me. So can you please help here @drrb and maybe add a discussion section for what needs to be done? What the progress of the parser is. Do we really need it or we switch to textmate lexer and use language server for Rust, etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants