Add null check for relativeTo parameter in GetTabletToElementTransform
#10107
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form` Modified the `GetTabletToElementTransform` method to include a null check for the `relativeTo` parameter. The `StylusDevice.GetElementTransform(relativeTo)` is now only added to the `group` when `relativeTo` is not null. This change reduces unnecessary method calls when `relativeTo` is null, minimizes allocations of the FrugalStructList within the `GeneralTransformCollection`, and enhances performance.
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Main PR
Description
Modified the
GetTabletToElementTransformmethod to include a null check for therelativeToparameter. TheStylusDevice.GetElementTransform(relativeTo)is now only added to thegroupwhenrelativeTois not null. This change reduces unnecessary method calls whenrelativeTois null, minimizes allocations of the FrugalStructList within theGeneralTransformCollection, and enhances performance.Customer Impact
Minor Performance Optimization
Regression
Testing
Just CI
Risk
Low. There are no logical dependencies. And the behavior before and after the code changes is identical.
Microsoft Reviewers: Open in CodeFlow