Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of profile attribute on files in windows desktop runtime pack are wrong #4708

Open
ThomasGoulet73 opened this issue Oct 4, 2024 · 1 comment
Milestone

Comments

@ThomasGoulet73
Copy link

Description

Some of the files tagged as WinForms and WPF in #4227 are wrong, these are all WPF specific and are not used by WinForms:

<FrameworkListFileClass Include="System.Xaml.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationClient.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationClientSideProviders.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationProvider.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="UIAutomationTypes.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="WindowsBase.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="WindowsFormsIntegration.resources.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="PenImc_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="vcruntime140_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Include="wpfgfx_cor3.dll" Profile="WindowsForms;WPF" />
<FrameworkListFileClass Condition="'$(PlatformTarget)' != 'ARM64'" Include="D3DCompiler_47_cor3.dll" Profile="WindowsForms;WPF" />

The .resources.dll files in this bloc are tagged as WPF and WinForms when the regular dll is tagged as WPF only. Which means that in the publish you get the .resources.dll file without the matching .dll file.

For WindowsFormsIntegration.resources.dll it's unclear because the regular dll file is tagged as WPF and WinForms when AFAIK it shouldn't be used when it's WinForms only:

<FrameworkListFileClass Include="WindowsFormsIntegration.dll" Profile="WindowsForms;WPF"/>

If I do the steps to reproduce in the issue dotnet/sdk#37088, I get those files in the output when they shouldn't be used at runtime.

/cc @LakshanF since you were the one to add the file.

@RussKie
Copy link
Member

RussKie commented Oct 8, 2024

The change to how Windows Forms classifications are references was made incorrectly too: https://github.com/dotnet/windowsdesktop/pull/4227/files#r1791003324, and that should be rectified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants