Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCF packages should be auto-updated #3677

Open
ViktorHofer opened this issue Jun 21, 2023 · 3 comments
Open

WCF packages should be auto-updated #3677

ViktorHofer opened this issue Jun 21, 2023 · 3 comments

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 21, 2023

WCP packages should be auto-updated. Otherwise those package dependencies in the Microsoft.Windows.Compatibility package would be stale:

<SystemServiceModelVersion>4.10.0</SystemServiceModelVersion>

Presumably that could be accomplished by using dependabot in the repository.

cc @dreddy-work @mmitche @carlossanlop

@dreddy-work
Copy link
Member

@mmitche, anyways to auto-update this? Does dependabot need any configuration in the repo to identify this package and version?

@mmitche
Copy link
Member

mmitche commented Jun 21, 2023

I think it needs to be configured in this repo for general version updates. I'm not sure how flexible it is, but you might take a look at the documentation https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates to see how to configure it for a subset of dependencies. We don't want it updating versions of dependencies within the stack (e.g, runtime).

I don't think it will automatically figure out that this property needs an update. For one thing, it doesn't know that this is a dependency, https://github.com/dotnet/windowsdesktop/network/dependencies, and secondly, System.ServiceModel isn't actually a package in the first place (it's a proxy name for a number of packages under System.ServiceModel.*).

@ViktorHofer
Copy link
Member Author

Here's how dependabot works in the msbuild repo: https://github.com/dotnet/msbuild/tree/main/eng/dependabot

They specify a set of dependencies that should be auto-updated by dependabot. Everything else is either static or updated via dependency flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants