Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce WindowsDesktop DLL/EXE files having non-zero FileVersion #1282

Open
dagood opened this issue Apr 5, 2019 · 2 comments
Open

Enforce WindowsDesktop DLL/EXE files having non-zero FileVersion #1282

dagood opened this issue Apr 5, 2019 · 2 comments

Comments

@dagood
Copy link
Member

dagood commented Apr 5, 2019

https://github.com/dotnet/core-setup/blob/851859e9e07eda7adb2dcf129b0d6fb3cab411e3/src/pkg/projects/windowsdesktop/dir.props#L8-L17

dotnet/core-setup#5682 added validation that all DLL files in the platform manifest have a FileVersion that isn't null or 0.0.0.0. These WindowsDesktop files should be looked at so the validation suppression can be removed.

This is only a sanity check: there may be a valid reason, and this doesn't seem like a high priority.

First step is to identify where these files are created.

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@NikolaMilosavljevic NikolaMilosavljevic transferred this issue from dotnet/runtime Dec 7, 2020
@RussKie
Copy link
Member

RussKie commented Dec 7, 2020

@ryalanms would any of these be coming with WPF?

@dreddy-work
Copy link
Member

Addign @pchaurasia14 / @singhashish-wpf to follow-up and close it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants