Fix incorrect apphost being used when publishing for self-contained single-file with NoBuild=true
#45060
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ILLink
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_GetAppHostCreationConfigurationtarget sets the_UseSingleFileHostForPublishproperty, which determines if we (re-)create the app usingsinglefilehoston publish. When publishing withNoBuild=true, the target was not being run, so we bundled usingapphost, resulting in an app that was configured to be self-contained but did not actually have the runtime as part of itself.This change chains the target into the computation for output paths to ensure that the target runs when publishing without building, so that the correct host is used.
See https://developercommunity.visualstudio.com/t/Single-file-self-contained-failing-after/10794374