Use arcade infra for DEB and RPM build #45047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
requested review from
jkoritzinsky,
ViktorHofer,
mmitche,
marcpopMSFT and
MiYanni
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43688
This enables SDK to use shared infrastructure for DEB and RPM build. It also uses the latest tooling implemented by @jkoritzinsky which enables us to run the build on containers without special tooling, i.e. FPM/dep-package-tool. I have updated the pipeline to use simple containers.
Previously, there was a simple test that ensured installation of SDK package, along with all of the dependencies. The test had limited value. I have created an issue (epic) to track all improvements around installer testing - dotnet/runtime#109736, as well as package installation - dotnet/runtime#109848
Manpages were never installed with SDK package even though there was some 'code' in the old infra. There was a bug in that code. New shared infrastructure supports manpages but due to a current issue, it does not install them to the correct location. I have created two issues to track relevant fixes:: dotnet/arcade#15243 and #44833
There are some minor differences in metadata contents. It, now, better matches other .NET packages, i.e. those produced by
runtime. I will be following up on these differences to understand their significance - will create issues if necessary.Testing
Fully tested with internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2586841&view=results