Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT Populate source link information in the final PDB #81415

Open
Tracked by #79241
vitek-karas opened this issue Jan 31, 2023 · 4 comments
Open
Tracked by #79241

NativeAOT Populate source link information in the final PDB #81415

vitek-karas opened this issue Jan 31, 2023 · 4 comments
Assignees
Milestone

Comments

@vitek-karas
Copy link
Member

Currently the NativeAOT compiler uses the source PDBs to produce one final PDB for the app, but it doesn't propagate source link information to the final PDB. This makes debugging into anything but the app's code a degraded experience.

This issue tracks:
[ ] - Investigate if there's some mechanism for source-link on Linux and macOS
[ ] - Implement propagating source-link at least on Windows

Per @MichalStrehovsky:
I tried looking into that 3 years ago and it didn’t look too complicated. We need to extract the source link information json from the individual compilands, combine the json, write out the json to a file and pass it to link.exe. At least on Windows.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently the NativeAOT compiler uses the source PDBs to produce one final PDB for the app, but it doesn't propagate source link information to the final PDB. This makes debugging into anything but the app's code a degraded experience.

This issue tracks:
[ ] - Investigate if there's some mechanism for source-link on Linux and macOS
[ ] - Implement propagating source-link at least on Windows

Per @MichalStrehovsky:
I tried looking into that 3 years ago and it didn’t look too complicated. We need to extract the source link information json from the individual compilands, combine the json, write out the json to a file and pass it to link.exe. At least on Windows.

Author: vitek-karas
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@agocke agocke added this to AppModel Feb 14, 2023
@agocke agocke added this to the 8.0.0 milestone Feb 14, 2023
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Feb 14, 2023
@agocke agocke modified the milestones: 8.0.0, 9.0.0 Aug 10, 2023
@agocke agocke removed this from the 9.0.0 milestone Jan 4, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 4, 2024
@agocke agocke added this to the 9.0.0 milestone Jan 4, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 4, 2024
@agocke agocke added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jan 4, 2024
@MichalStrehovsky MichalStrehovsky modified the milestones: 9.0.0, 10.0.0 Jun 26, 2024
@agocke
Copy link
Member

agocke commented Nov 26, 2024

@MichalStrehovsky Can you take a look at this? Feedback has pushed this one up in priority.

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky Can you take a look at this? Feedback has pushed this one up in priority.

Do you have any more details on the feedback - what platform is this? I think we can only support this on Windows out of the box. We'd likely need to build a native debugger plugin for Linux.

@agocke
Copy link
Member

agocke commented Nov 26, 2024

Yup, Windows-only for now. We can come back to Linux/Mac later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants