Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary EOL package references #76073

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 25, 2024

Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository.

This change might be considered a breaking change as packages like System.Memory are being updated which are considered highly impactful and might also require coordination with VS.

Tries to unblock dotnet/sdk#45042

@ViktorHofer ViktorHofer requested a review from a team as a code owner November 25, 2024 16:52
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 25, 2024
@ViktorHofer ViktorHofer requested a review from a team as a code owner November 25, 2024 17:13
@ViktorHofer
Copy link
Member Author

@jaredpar can someone on your team please take a look at the MissingMethodException failure. This looks related to the System.Memory version bump.

@ViktorHofer ViktorHofer changed the title Update package versions and remove unnecessary EOL package references Remove unnecessary EOL package references Nov 27, 2024
@ViktorHofer
Copy link
Member Author

Now that #76076 is merged, I rebased on top of it. The changes here remove package references and package versions that aren't necessary anymore because the assembly got moved inbox. The xunit version used in roslyn now targets netstandard2.0 as well so workaround can be removed for that as well.

@ViktorHofer ViktorHofer merged commit f614346 into main Nov 29, 2024
28 checks passed
@ViktorHofer ViktorHofer deleted the UpdatePackageVersions branch November 29, 2024 08:35
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants