Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Hide/show titlebar on modal pages #26071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Foda
Copy link
Member

@Foda Foda commented Nov 22, 2024

Description of Change

Toggle the titlebar visibility when modal pages are pushed/popped.

Issues Fixed

Fixes #25964

@Foda Foda requested a review from a team as a code owner November 22, 2024 20:10
@PureWeen
Copy link
Member

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11981567160

@mattleibow
Copy link
Member

Can we get tests for this one?

@PureWeen
Copy link
Member

Can we get tests for this one?

we could probably validate the raw control.
The screen shot tests don't work because we cut off the titlebar so we can use screen comparison tests :-/

We're going to add a manual test as well here for validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

[WinUI] App TitleBar overlapping on .NET9 when using Modals
3 participants