[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 16 #26029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nivetha-nagalingam <nivetha.nagalingam@syncfusion.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 22, 2024
| @@ -1,4 +1,5 @@ | |||
| using NUnit.Framework; | |||
| #if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_WINDOWS //Issue reproduced and logged: https://github.com/dotnet/maui/issues/26019. | |||
There was a problem hiding this comment.
The issue was a duplicated and has been closed, could you update the comment to replace it by #26026?
| /// <param name="app">The IApp instance.</param> | ||
| /// <param name="elementId">The id of the element to wait for.</param> | ||
| /// <param name="timeout">Optional timeout for the wait operation. Default is null, which uses the default timeout.</param> | ||
| public static void WaitForElementTillPageNavigationSettled(this IApp app, string elementId, TimeSpan? timeout = null) |
There was a problem hiding this comment.
Could include another override passing IQuery query as parameter instead the elementId? In that way we can wait for elements based on a query.
| app.Tap(AppiumQuery.ByAccessibilityId("NavigationViewBackButton")); | ||
| /// <param name="app">The IApp instance representing the main gateway to interact with the application.</param> | ||
| /// <param name="customBackButtonIdentifier">Optional. The custom identifier for the back button. If not provided, default platform-specific identifiers will be used.</param> | ||
| public static void TapBackArrow(this IApp app, string customBackButtonIdentifier = "") |
There was a problem hiding this comment.
Why not split in two methods?
static void TapBackArrow(this IApp app);
static void TapBackArrow(this IApp app, IQuery query);
The first one will just use the default platform-specific identifiers and the second one will allow any custom query like for example AppiumQuery.ByAccessibilityId("Back")
| App.WaitForElementTillPageNavigationSettled(PushNewPage); | ||
| App.Tap(PushNewPage); | ||
| App.WaitForElementTillPageNavigationSettled(TabPage2); | ||
| App.Tap(TabPage2); |
There was a problem hiding this comment.
Mnnn, maybe I could include a TapTab method that internally does the wait, and also in the case of Android the ToUpperCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 16th group of tests enabled.
Add WaitForElementTillPageNavigationSettled Extension Method
Description
Also introduces a new extension method
WaitForElementTillPageNavigationSettledto enhance the stability of UI tests, particularly for MacCatalyst applications. The method provides a more robust way to wait for elements during page transitions, helping to prevent null reference exceptions.TestCases