Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Editor and ScrollView problems in iOS #26024

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NirmalKumarYuvaraj
Copy link
Contributor

Issue Details:

Editor's width and height is not updated when changing the device orientation from landscape to portrait.

Root Cause:

When changing the device orientation from landscape to portrait, the Editor view retains its previous landscape bounds, as the bounds for the PlatformView of the Editor are not updated during the new layout pass from the parent. This issue occurs when the Editor is placed inside a nested ScrollView and Grid. The size of the grid (the presented content inside the first ScrollView) is not updated during the layout pass. As a result, the layout of subsequent children, such as the Border, second ScrollView, and the Editor itself, does not update correctly, causing the width and height to remain incorrect.

Description of Change:

I’ve called the scrollView.ArrangeContentUnbounded(Frame) method within the ArrangeOverride method of the ScrollView class. This ensures that the presented content (the Grid) updates its size, along with its child elements, including the Border, inner ScrollView, and Editor.

Tested the behavior in the following platforms.

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed:

Fixes #22946

Screenshots

Before Issue Fix After Issue Fix

Fixed Editor and ScrollView problems in iOS
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 21, 2024
Copy link
Contributor

Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Added platform-specific condition to skip the test case on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor and ScrollView problems in iOS
3 participants