[Windows] Fix crash setting MenuFlyoutSubItem IconImageSource #26021
+173
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
PureWeen
requested changes
Nov 21, 2024
Added both, xlml test and UITest. |
mattleibow
requested changes
Nov 22, 2024
| @@ -16,7 +16,12 @@ public partial class MenuFlyoutSubItem : MenuFlyoutItem, IMenuFlyoutSubItem | |||
|
|
|||
| public MenuFlyoutSubItem() | |||
| { | |||
| LogicalChildrenInternalBackingStore = new CastingList<Element, IMenuElement>(_menus); | |||
There was a problem hiding this comment.
I think the casting list is a wrapper and if you change the source is is also reflected.
Adding new items to a new list is not going to keep them synced.
Can we use the casting list still and just go to Element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash setting
MenuFlyoutSubItemIconImageSource on Windows.From #24688 the ImageSource is added as logical children of the menu item. However, the
LogicalChildrenInternalBackingStorecollection from MenuFlyoutSubItem does a casting toIMenuElementmaui/src/Controls/src/Core/Menu/MenuFlyoutSubItem.cs
Line 19 in 5b5aaa5
Trying to add the IconImageSource to the LogicalChildrenInternalBackingStore insert a null value because this casting
maui/src/Controls/src/Core/ReadOnlyCastingList.cs
Line 91 in 5b5aaa5
IMenuElement.This PR apply changes to allow Element in the
LogicalChildrenInternalBackingStorecollection from MenuFlyoutSubItem.Issues Fixed
Fixes #25893