Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dll file reference leads to CS1025 error in latest release #3753

Closed
2 of 17 tasks
dgpratt opened this issue Nov 11, 2024 · 5 comments
Closed
2 of 17 tasks

Dll file reference leads to CS1025 error in latest release #3753

dgpratt opened this issue Nov 11, 2024 · 5 comments
Assignees
Labels
Area-Packages and Extensions Related to acquiring and using packages and extensions bug Something isn't working

Comments

@dgpratt
Copy link

dgpratt commented Nov 11, 2024

Describe the bug

I have a C# based notebook that prior to the latest update to the VS Code plugin was working fine. After the last plugin update (to v1.0.5530010, released on 2024-10-30, 12:24:40), it seems file (DLL) references cause an error (displayed in the cell output area):

Error: (2,136): error CS1025: Single-line comment or end-of-line expected

To be clear, this is for references in the form:

#r "C:\..\Example.dll"

Nuget references (e.g. #r "nuget: Microsoft.Data.SqlClient") continue to work fine.

Please complete the following:

Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

Version: 1.0.553001+f0ec3826954ea1ab829b435418328e4aa8db58e2

Library version: 1.0.0-beta.24530.1+f0ec3826954ea1ab829b435418328e4aa8db58e2

Build date: 2024-11-06T19:03:33.2387602Z

  • OS
    • Windows 11
    • Windows 10
    • macOS
    • Linux (Please specify distro)
    • iOS
    • Android
  • Browser
    • Chrome
    • Edge
    • Firefox
    • Safari
  • Frontend
    • Jupyter Notebook
    • Jupyter Lab
    • nteract
    • Visual Studio Code
    • Visual Studio Code Insiders
    • Visual Studio
    • Other (please specify)

Screenshots

If applicable, add screenshots to help explain your problem.

@jonsequitur
Copy link
Contributor

I'm unable to reproduce this issue.

Are you able to get it to work with a different .dll? Can you provide additional information such as the exact code that's failing?

@jonsequitur jonsequitur added bug Something isn't working waiting-on-feedback Area-Packages and Extensions Related to acquiring and using packages and extensions labels Nov 11, 2024
@konst-sh
Copy link

konst-sh commented Nov 13, 2024

Confirming this, if in the same cell I have a few of #r directives for local .dll files and #r nuget directives it doesn't work anymore for F# lang. If I move #r directives for nugets it into separate cell it still works.

@jonsequitur
Copy link
Contributor

Can you provide code that reproduces the issue? I'm still unable to do so.

@konst-sh
Copy link

@jonsequitur this file and a pair of local dll's reproduces the issue for me, the dll's are just two random ones
Polyglot notebook reference dll issue.zip

@bdbai
Copy link

bdbai commented Nov 25, 2024

I’m also having this issue. I have a main.ipynb that references a util.csx using #!import util.csx syntax. Inside util.csx, it loads a few dlls like #r "System.Net.Http.Json.dll" and #r "Microsoft.AspNetCore.WebUtilities.dll". When executing the main notebook, it shows the same error.

Ployglot Notebooks 1.0.5229040 doesn’t have this issue though.

@jonsequitur jonsequitur self-assigned this Nov 25, 2024
jonsequitur added a commit to jonsequitur/interactive that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Packages and Extensions Related to acquiring and using packages and extensions bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants