From e980b37395f511e31572452d7c25ccafb6f5d0b7 Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Mon, 25 Nov 2024 13:43:18 +0100
Subject: [PATCH] Test2

---
 eng/Build.props                   | 29 +++--------------------------
 eng/Build/Build.Traversal.proj    | 24 ++++++++++++++++++++++++
 eng/Build/Directory.Build.targets | 23 +++++++++++++++++++++++
 eng/Build/Managed.Traversal.proj  |  8 --------
 eng/Build/NodeJS.Traversal.proj   |  1 -
 eng/helix/helix.proj              |  8 +++-----
 6 files changed, 53 insertions(+), 40 deletions(-)
 create mode 100644 eng/Build/Build.Traversal.proj
 create mode 100644 eng/Build/Directory.Build.targets

diff --git a/eng/Build.props b/eng/Build.props
index 7d7ef9d1e29b..1fe548b2dc46 100644
--- a/eng/Build.props
+++ b/eng/Build.props
@@ -1,30 +1,7 @@
 <Project>
 
-  <Import Project="$(MSBuildThisFileDirectory)Common.props" />
-  <Import Project="$(MSBuildThisFileDirectory)Build\Directory.Build.props" />
-
-  <Choose>
-    <!-- Project selection can be overridden on the command line by passing in -projects. -->
-    <When Condition="'$(ProjectToBuild)' != ''">
-      <ItemGroup>
-        <ProjectToBuild Include="$(ProjectToBuild)"
-            Exclude="@(ProjectToExclude);$(RepoRoot)**\bin\**\*;$(RepoRoot)**\obj\**\*">
-          <BuildInParallel Condition=" '%(Extension)' == '.nodeproj' OR '%(Extension)' == '.vcxproj' ">false</BuildInParallel>
-          <RestoreInParallel Condition=" '%(Extension)' == '.nodeproj' ">false</RestoreInParallel>
-          <!-- Also do not build in parallel w/in npm projects. -->
-          <AdditionalProperties Condition=" '%(Extension)' == '.nodeproj' OR '%(Extension)' == '.vcxproj' ">BuildInParallel=false</AdditionalProperties>
-        </ProjectToBuild>
-      </ItemGroup>
-    </When>
-    <Otherwise>
-      <ItemGroup>
-        <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\Native.Traversal.proj" Condition="'$(BuildNative)' == 'true'" BuildInParallel="false" />
-        <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\NodeJS.Traversal.proj" Condition="'$(BuildNodeJS)' == 'true'" BuildInParallel="false" />
-        <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\Java.Traversal.proj" Condition="'$(BuildJava)' == 'true'" BuildInParallel="false" />
-        <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\Managed.Traversal.proj" Condition="'$(BuildManaged)' == 'true'" BuildInParallel="false" />
-        <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\Installers.Traversal.proj" Condition="'$(BuildInstallers)' == 'true'" BuildInParallel="false" />
-      </ItemGroup>
-    </Otherwise>
-  </Choose>
+  <ItemGroup>
+    <ProjectToBuild Include="$(MSBuildThisFileDirectory)Build\Build.Traversal.proj" />
+  </ItemGroup>
 
 </Project>
diff --git a/eng/Build/Build.Traversal.proj b/eng/Build/Build.Traversal.proj
new file mode 100644
index 000000000000..e66695d22242
--- /dev/null
+++ b/eng/Build/Build.Traversal.proj
@@ -0,0 +1,24 @@
+<Project Sdk="Microsoft.Build.Traversal">
+
+  <Choose>
+    <!-- Project selection can be overridden on the command line by passing in -projects. -->
+    <When Condition="'$(ProjectToBuild)' != ''">
+      <ItemGroup>
+        <ProjectReference Include="$(ProjectToBuild)"
+          Exclude="@(ProjectToExclude);$(RepoRoot)**\bin\**\*;$(RepoRoot)**\obj\**\*">
+          <BuildInParallel Condition=" '%(Extension)' == '.nodeproj' OR '%(Extension)' == '.vcxproj' ">false</BuildInParallel>
+        </ProjectReference>
+      </ItemGroup>
+    </When>
+    <Otherwise>
+      <ItemGroup>
+        <ProjectReference Include="Native.Traversal.proj" Condition="'$(BuildNative)' == 'true'" BuildInParallel="false" />
+        <ProjectReference Include="NodeJS.Traversal.proj" Condition="'$(BuildNodeJS)' == 'true'" BuildInParallel="false" />
+        <ProjectReference Include="Java.Traversal.proj" Condition="'$(BuildJava)' == 'true'" BuildInParallel="false" />
+        <ProjectReference Include="Managed.Traversal.proj" Condition="'$(BuildManaged)' == 'true'" BuildInParallel="false" />
+        <ProjectReference Include="Installers.Traversal.proj" Condition="'$(BuildInstallers)' == 'true'" BuildInParallel="false" />
+      </ItemGroup>
+    </Otherwise>
+  </Choose>
+
+</Project>
diff --git a/eng/Build/Directory.Build.targets b/eng/Build/Directory.Build.targets
new file mode 100644
index 000000000000..22642fc2382a
--- /dev/null
+++ b/eng/Build/Directory.Build.targets
@@ -0,0 +1,23 @@
+<Project>
+
+  <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.targets, $(MSBuildThisFileDirectory)..))" />
+
+  <Target Name="GetReferencesProvided" Returns="@(ProvidesReferenceOrRequiresDelay)">
+    <MSBuild Projects="@(ProjectReference);@(ExplicitRequiresDelay)"
+             Targets="GetReferencesProvided"
+             BuildInParallel="true"
+             SkipNonexistentTargets="true">
+      <Output TaskParameter="TargetOutputs" ItemName="ProvidesReferenceOrRequiresDelay" />
+    </MSBuild>
+  </Target>
+
+  <Target Name="CreateHelixPayload" Returns="@(HelixWorkItem)">
+    <MSBuild Projects="@(ProjectReference)"
+             Targets="CreateHelixPayload"
+             BuildInParallel="true"
+             SkipNonexistentTargets="true">
+      <Output TaskParameter="TargetOutputs" ItemName="HelixWorkItem" />
+    </MSBuild>
+  </Target>
+
+</Project>
\ No newline at end of file
diff --git a/eng/Build/Managed.Traversal.proj b/eng/Build/Managed.Traversal.proj
index 5dc72298a7e8..7219bc0c5707 100644
--- a/eng/Build/Managed.Traversal.proj
+++ b/eng/Build/Managed.Traversal.proj
@@ -103,12 +103,4 @@
                     Condition=" '$(BuildMainlyReferenceProviders)' == 'true' " />
   </ItemGroup>
 
-  <Target Name="GetReferencesProvided" Returns="@(ProvidesReferenceOrRequiresDelay)">
-    <MSBuild Projects="@(ProjectReference);@(ExplicitRequiresDelay)"
-             Targets="GetReferencesProvided"
-             BuildInParallel="true">
-      <Output TaskParameter="TargetOutputs" ItemName="ProvidesReferenceOrRequiresDelay" />
-    </MSBuild>
-  </Target>
-
 </Project>
diff --git a/eng/Build/NodeJS.Traversal.proj b/eng/Build/NodeJS.Traversal.proj
index 2f80ddc46109..486e6beac764 100644
--- a/eng/Build/NodeJS.Traversal.proj
+++ b/eng/Build/NodeJS.Traversal.proj
@@ -4,7 +4,6 @@
     <ProjectReference
       Include="$(RepoRoot)eng\Npm.Workspace.nodeproj;
                $(RepoRoot)eng\Npm.Workspace.FunctionalTests.nodeproj"
-      RestoreInParallel="false"
       BuildInParallel="false"
       Exclude="@(ProjectToExclude)" />
   </ItemGroup>
diff --git a/eng/helix/helix.proj b/eng/helix/helix.proj
index db6d0608adff..497c7e25b9b2 100644
--- a/eng/helix/helix.proj
+++ b/eng/helix/helix.proj
@@ -15,7 +15,7 @@
   </PropertyGroup>
 
   <Import Project="..\targets\Helix.Common.props" />
-  <Import Project="..\Build.props" />
+  <Import Project="..\Common.props" />
   <Import Project="..\Versions.props" />
 
   <!-- Microsoft.DotNet.Helix.Sdk.MultiQueue.targets splits $(HelixTargetQueues) into @(HelixTargetQueue) items. -->
@@ -165,10 +165,8 @@
 
   <!-- In inner (per-queue) builds, Publish the test projects and create work items. -->
   <Target Name="Gather" BeforeTargets="BeforeTest" Condition=" '$(HelixTargetQueue)' != '' ">
-    <MSBuild Projects="@(ProjectToBuild)"
-        BuildInParallel="%(ProjectToBuild.BuildInParallel)"
-        Targets="CreateHelixPayload"
-        SkipNonexistentTargets="true">
+    <MSBuild Projects="..\Build\Build.Traversal.proj"
+        Targets="CreateHelixPayload">
       <Output TaskParameter="TargetOutputs" ItemName="HelixWorkItem" />
     </MSBuild>
   </Target>