Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily uninstall pkg-config@0.29.2 in install-dependencies.sh #15259

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

akoeplinger
Copy link
Member

This was added by AzDO in actions/runner-images#10971 as a workaround for actions/runner-images#10984, but that means the old package now conflicts with the new pkg-config which is an alias to pkgconf.

Fixes the build issues we've seen with OSX image version 20241119.505

Port of dotnet/runtime#109968 to arcade

This was added by AzDO in actions/runner-images#10971 as a workaround for actions/runner-images#10984, but that means the old package now conflicts with the new pkg-config which is an alias to pkgconf.

Fixes the build issues we've seen with OSX image version 20241119.505
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@am11
Copy link
Member

am11 commented Nov 19, 2024

An alternative is to pin the same version with @ syntax few lines below (assuming it's not breaking the runtime build), but this fix is also good.

@akoeplinger
Copy link
Member Author

Yeah I thought about that but it will stop working when AzDO removes the custom tap that provides 0.29.0 while this solution will then just no-op.

@akoeplinger akoeplinger merged commit 6c4799b into main Nov 19, 2024
11 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch November 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants