-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable signing and notarization of .pkg files using SignTool #14435
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Assigning myself for now since I've been working on this in parallel with #14438. The piece that I'm missing is the entitlements. I'll discuss this more when I open the draft PR since then I'll be able to point to the section of code that I think we may need to add entitlements with. |
This is the current commit with the changes for signing. This commit sits on top of #15205 and #15206. Some things that were unclear with these task that will need to be addressed before the changes are ready for PR:
|
T-Shirt Size: S/M Requires reworking of the current infra for signing osx extensions given this documentation: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/19841/Additional-Requirements-for-Signing-or-Notarizing-Mac-Files?anchor=visual-studio-project-files |
There are a couple interesting points here:
Our existing signing infra has us applying entitlements to dotnet, createdump, etc. I need to determine whether these entitlements have already been applied by other repos. Is it necessary to re-apply them? |
It does look like entitlements are already added and do not need to be re-added. Confirming |
Enable SignTool to process and and submit MacOS .pkgs for signing and notarization. Because notarization can only happen on a Mac machine, this requires #14431 to be complete.
One place to start with this is looking at what we do in the staging pipelines.
The text was updated successfully, but these errors were encountered: