[Xamarin.Android.Build.Tasks] fix incremental builds for _GenerateAndroidRemapNativeCode
#9548
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we are randomly seeing a test failure like:
Sometimes, it passes and sometimes not.
Reviewing the
.binlog
I noticed under the top 10 expensive tasks:Which I found by the target:
Which has the
Inputs/Outputs
:Reviewing the target, it feels like we should fix the
Inputs
andOutputs
, such as:Inputs
should include all MSBuild files@(_AndroidMSBuildAllProjects)
, as settings could be inDirectory.Build.props
, etc.Inputs
should includebuild.props
if that file changes to force a rerun.We should
<Touch/>
theOutputs
files to prevent the target from running when it doesn't need to.After these changes, I'm hoping
Build_AndroidResource_Change
passes more reliably, we will see.