Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<AndroidMavenLibrary> support for nonstandard artifact filenames #9465

Closed
FA72 opened this issue Oct 29, 2024 · 1 comment · Fixed by #9479
Closed

<AndroidMavenLibrary> support for nonstandard artifact filenames #9465

FA72 opened this issue Oct 29, 2024 · 1 comment · Fixed by #9479
Assignees
Labels
Area: Bindings Issues in Java Library Binding projects. enhancement Proposed change to current functionality.
Milestone

Comments

@FA72
Copy link

FA72 commented Oct 29, 2024

Android framework version

net9.0-android

Affected platform version

VS 2022 Preview v. 17.12.0 Preview 4.0

Description

Hello! I encountered an issue where, when loading certain .aar files from Maven, the version number also specifies a debug/release parameter. The easiest way to illustrate this is with a ReactNative library example. There, you have react-android-0.76.0-debug.aar and react-android-0.76.0-release.aar. With the current setup and using the line:

<AndroidMavenLibrary Include="com.facebook.react:react-android" Version ="0.76.0"/>
the following error occurs:

1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\35.0.0-rc.2.152\tools\Xamarin.Android.Bindings.Maven.targets(28,5): error XA4236: Cannot download Maven artifact 'com.facebook.react:react-android'.
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\35.0.0-rc.2.152\tools\Xamarin.Android.Bindings.Maven.targets(28,5): error XA4236: - react-android-0.76.0.jar: Response status code does not indicate success: 404 (Not Found).
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\35.0.0-rc.2.152\tools\Xamarin.Android.Bindings.Maven.targets(28,5): error XA4236: - react-android-0.76.0.aar: Response status code does not indicate success: 404 (Not Found).

Steps to Reproduce

  1. File > New Project > Android Java Library Binding > Create
  2. Open .csproj File
  3. Add
<ItemGroup>
	<AndroidMavenLibrary Include="com.facebook.react:react-android" Version ="0.76.0"/>
</ItemGroup>
  1. Build project

Did you find any workaround?

No response

Relevant log output

No response

@FA72 FA72 added the needs-triage Issues that need to be assigned. label Oct 29, 2024
@jpobst jpobst added Area: Bindings Issues in Java Library Binding projects. enhancement Proposed change to current functionality. and removed needs-triage Issues that need to be assigned. labels Oct 29, 2024
@jpobst jpobst added this to the .NET 10 milestone Oct 29, 2024
@jpobst
Copy link
Contributor

jpobst commented Oct 29, 2024

Hmm, I guess we'll need to add some sort of metadata that allows one to specify the filename like:

<AndroidMavenLibrary Include="com.facebook.react:react-android" Version="0.76.0" ArtifactFilename="react-android-0.76.0-release.aar" />

@jpobst jpobst changed the title AndroidMavenLibrary not supported release/debug .aap <AndroidMavenLibrary> support for nonstandard filenames Oct 29, 2024
@jpobst jpobst changed the title <AndroidMavenLibrary> support for nonstandard filenames <AndroidMavenLibrary> support for nonstandard artifact filenames Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bindings Issues in Java Library Binding projects. enhancement Proposed change to current functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants