Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: DOME_Color.value seems to be ordered as 0xAABBGGRR but docs say It's 0xAARRGGBB #229

Open
trelemar opened this issue Jan 12, 2022 · 5 comments

Comments

@trelemar
Copy link
Contributor

No description provided.

@avivbeeri
Copy link
Collaborator

That's probably just me messing up the order (byte order is always confusing). The only other reason it might be wrong is if your device is a different "endianness" to standard, but that would have resulted in many more problems.

@avivbeeri
Copy link
Collaborator

Following up on this, can you check your device architecture for me, so we can figure out which option is correct? Thanks :)

@trelemar
Copy link
Contributor Author

This was on lubuntu 64 bit. I will test with other architectures and try to replicate as well

@avivbeeri
Copy link
Collaborator

It's more about the processor than operating system: ARM, AMD and Intel chips all use different byte arrangements in memory. I may have just messed it up on my end when documenting it though.

@avivbeeri
Copy link
Collaborator

I've corrected the docs for this, I just need to double check that the DOME_Color struct is correct too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants