You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that __init__.py files do not exist in core and db folders. Though, core is used as a python package.
Indeed, this is valid Python, and it will work with a Python interpreter in a version greater than 3.3.
However, I think adding these files would be a better practice to indicate that core and db are Python packages.
First, packages without __init__.py files or namespace package are usually used to organize multiple packages, which is not the intention here.
Also, __init__.py files are present in similar projects like for example in skflabs
Would it be possible to add __init__.py in the core and db folders so they will be standard python packages? If you agree, I'll create a PR for this.
Thanks!
The text was updated successfully, but these errors were encountered:
Hello!
I noticed that
__init__.py
files do not exist incore
anddb
folders. Though,core
is used as a python package.Indeed, this is valid Python, and it will work with a Python interpreter in a version greater than 3.3.
However, I think adding these files would be a better practice to indicate that
core
anddb
are Python packages.First, packages without
__init__.py
files or namespace package are usually used to organize multiple packages, which is not the intention here.Also,
__init__.py
files are present in similar projects like for example in skflabsWould it be possible to add
__init__.py
in thecore
anddb
folders so they will be standard python packages? If you agree, I'll create a PR for this.Thanks!
The text was updated successfully, but these errors were encountered: