Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing __init__.py files in core and db folder #80

Closed
thomas-serre-sonarsource opened this issue Oct 19, 2023 · 3 comments
Closed

Missing __init__.py files in core and db folder #80

thomas-serre-sonarsource opened this issue Oct 19, 2023 · 3 comments

Comments

@thomas-serre-sonarsource
Copy link
Contributor

Hello!

I noticed that __init__.py files do not exist in core and db folders. Though, core is used as a python package.
Indeed, this is valid Python, and it will work with a Python interpreter in a version greater than 3.3.

However, I think adding these files would be a better practice to indicate that core and db are Python packages.
First, packages without __init__.py files or namespace package are usually used to organize multiple packages, which is not the intention here.
Also, __init__.py files are present in similar projects like for example in skflabs

Would it be possible to add __init__.py in the core and db folders so they will be standard python packages? If you agree, I'll create a PR for this.
Thanks!

@dolevf
Copy link
Owner

dolevf commented Nov 1, 2023

Hi there. Yes, this is possible!

@thomas-serre-sonarsource
Copy link
Contributor Author

Alright. I've created the PR.
Thanks!

@thomas-serre-sonarsource
Copy link
Contributor Author

I'll close the issue once the PR is merged ;)

@dolevf dolevf closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants