Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v1 AdmissionReview #4

Closed
sagikazarmark opened this issue Sep 27, 2020 · 6 comments · Fixed by #17
Closed

Add support for v1 AdmissionReview #4

sagikazarmark opened this issue Sep 27, 2020 · 6 comments · Fixed by #17
Assignees
@alexei-led
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sagikazarmark
Copy link
Contributor

FYI I opened an issue in the upstream webhook repo to add support for this: slok/kubewebhook#72
@alexei-led
Copy link
Collaborator

fixed with 0.2.15

@sagikazarmark
Copy link
Contributor Author

@alexei-led unfortunately, that's not enough. Please see the issue I linked.

@alexei-led alexei-led self-assigned this Feb 23, 2021
@alexei-led alexei-led reopened this Feb 23, 2021
@alexei-led
Copy link
Collaborator

@sagikazarmark indeed, reopening the issue

@alexei-led alexei-led added enhancement New feature or request help wanted Extra attention is needed labels Feb 23, 2021
@alexei-led
Copy link
Collaborator

update to kubewebhook v2 once released (beta now)

@sagikazarmark
Copy link
Contributor Author

Maybe update and release a beta as well? I think the author is waiting for some feedback: slok/kubewebhook#72 (comment)

@sagikazarmark
Copy link
Contributor Author

Looks like v2 is released.

@sagikazarmark sagikazarmark mentioned this issue Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexei-led alexei-led

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update kubewebhook sagikazarmark/kube-secrets-init
2 participants
@sagikazarmark @alexei-led