Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset CSS for student submission render #190

Open
BTWS2 opened this issue Nov 8, 2021 · 1 comment
Open

Reset CSS for student submission render #190

BTWS2 opened this issue Nov 8, 2021 · 1 comment
Labels
enhancement New feature or request high priority Things we want to see implemented soon
Milestone

Comments

@BTWS2
Copy link
Collaborator

BTWS2 commented Nov 8, 2021

The difference between the render with clean CSS and the render on Dodona isn't beneficial for the students. If the render is not reliable, a separate editor is required and it is less user-friendly.

If teachers want to grade HTML&CSS exercises it's easier if the render is reliable.

Rowspan isn't visible in this example.
table_5
fullname

The Dodona doesn't support iframes in the student submission render.

@bmesuere suggests these options:

  • solve with CSS
#tag { all: initial; }

#tag * { all: unset; }  /* or */

#tag * { all: revert; }

Docs:
https://developer.mozilla.org/en-US/docs/Web/CSS/all

Edit: Tested without the desired result.

  • Solve with iframe

"alles wat je in die ruby file opgeeft zal geoutput worden naar html je moet 2 dingen outputten:
een lege iframe (bv met een id, hoogte en breedte opgegeven)
en dan een script tag waar je bv via document.getElementById de iframe selecteert en dan de srcdoc property instelt" - Bart

"Iframe is miserie omdat je bv de hoogte niet automatisch goed krijgt en dan moet je JavaScript truuken uithalen om dat te fixen" - Bart

@BTWS2 BTWS2 added enhancement New feature or request high priority Things we want to see implemented soon labels Nov 8, 2021
@stijndcl
Copy link
Collaborator

stijndcl commented Nov 8, 2021

If the render is not reliable, a separate editor is required and it is less user-friendly.

Dodona is not an IDE, so a separate editor is required either way. Students shouldn't be coding in Dodona.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Things we want to see implemented soon
Projects
None yet
Development

No branches or pull requests

2 participants