Skip to content
This repository has been archived by the owner on Apr 22, 2022. It is now read-only.

Delete from Query, Elastica dependencies. #128

Open
Zyqsempai opened this issue Nov 28, 2016 · 2 comments
Open

Delete from Query, Elastica dependencies. #128

Zyqsempai opened this issue Nov 28, 2016 · 2 comments

Comments

@Zyqsempai
Copy link

Zyqsempai commented Nov 28, 2016

Here is the main problem: https://github.com/doctrine/search/blob/master/lib/Doctrine/Search/Query.php#L257
Here is two ways.
First one: We can create abstract layer for ResultSet, for example Adapter, and wrap all result sets.
Second one: We can move query on client level, create QueryInterface and realize it in ElasticSerach namespace for example, and create method in Client, something like Client::createQuery.
So each query will work only with his native ResultSet.
@MrHash What do you think?

@MrHash
Copy link
Contributor

MrHash commented Nov 29, 2016

My hunch is the second choice to create the query and result interfaces and implement for each technology.

@Zyqsempai
Copy link
Author

Ok. Deal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants