Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab support #145

Open
rsteenwyk opened this issue May 12, 2021 · 3 comments
Open

GitLab support #145

rsteenwyk opened this issue May 12, 2021 · 3 comments

Comments

@rsteenwyk
Copy link

First off, thanks for this extension, very cool!

Just curious how hard it would be to add support for Gitlab/internal instances of Gitlab?

@qmenoret
Copy link
Contributor

Hi!

I'm not 100% sure how hard it would be to add support for gitlab. Just a few thoughts:

  • If we want to support private gitlab instances, then we can't list the URLs we inject in anymore (so either we inject in all pages, or we let the users decide on which domains they want to use the extension)
  • Most of the logic can probably be reused, but we'd need to check if it's possible to access the files content on gitlab with simple requests from the extension (is the same workflow as the one we use on Github usable?)

I don't think we're speaking about too much work but I'll need to investigate a little bit. At least for the official Gitlab. I guess we'd start there and think about private instances later on, if it works fine. Do you know of any repos public where there are code tours available? Otherwise I'll create my own 🙂

@qmenoret
Copy link
Contributor

I actually went ahead and created my own repo on gitlab. It doesn't look too complicated but I'll need to refactor quite a bit to make it work without duplicating all the logic so I don't have an ETA just yet. I'll update here once I have a prototype and would be super happy to have you as a beta tester 😉

@rsteenwyk
Copy link
Author

Sounds good, happy to try it out on my internal instance when you get to that stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants