You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The regex pattern const pattern = /(\.show\(\))/gim; that injects createObject("roSGNode", "ODC") can cause unexpected injections in some scenarios.
I am currently working on a couple of Roku channels that set a string to showEventMessage = "example.show()".
When using the current pattern, this injects an additional unexpected createObject("roSGNode", "ODC") that looks like this:
Thanks @AntonKostenko for finding and reporting this case.
A fix for this case was added via #76 and became part of version 1.4.3.
In a future version I'll think about making the injection smarter (to take brightscript/xml into consideration) and optional (opt-in) in case of usage via appium
The regex pattern
const pattern = /(\.show\(\))/gim;
that injectscreateObject("roSGNode", "ODC")
can cause unexpected injections in some scenarios.I am currently working on a couple of Roku channels that set a string to
showEventMessage = "example.show()"
.When using the current pattern, this injects an additional unexpected
createObject("roSGNode", "ODC")
that looks like this:The misplaced quotes cause compilation errors.
Unfortunately I am unable to modify the roku app but a workaround I found was changing the pattern to:
https://github.com/dlenroc/node-roku/blob/main/packages/odc/src/internal/injector.ts#L61
Would you consider publishing a new package that account for this scenario?
The text was updated successfully, but these errors were encountered: