Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dub packages that have a submodule won't work #2747

Open
MrcSnm opened this issue Dec 21, 2023 · 3 comments
Open

Dub packages that have a submodule won't work #2747

MrcSnm opened this issue Dec 21, 2023 · 3 comments

Comments

@MrcSnm
Copy link
Contributor

MrcSnm commented Dec 21, 2023

System information

  • dub version: 1.36.0
  • OS Platform and distribution: All
  • compiler version All

Bug Description

If you include a git repository that contains submodules, those submodules aren't included in the dub dependency. It is okay as a default, but the problem is that the repo Is not cloned, which would mean, even git submodule update --init --recursive does not work since it is not a git repository.

How to reproduce?

Expected Behavior

Maybe the downloaded package could have an option to use git clone instead of downloading the .zip archive?
It could even have an alternate .zip download, since this way I would be able to supply a .zip archive containing the submodules.

I know dub is able to do the package management. But having more than one repo inside a repo makes it fairly easier to work with when I need.

Logs

@Geod24
Copy link
Member

Geod24 commented Dec 28, 2023

This is not an issue on dub side's though, the Github release does not include submodules.

@MrcSnm
Copy link
Contributor Author

MrcSnm commented Dec 29, 2023

This is not an issue on dub side's though, the Github release does not include submodules.

Hum but it would be better having a way to better distribute that. Do you have any idea? Unfortunately using preBuildCommands does not work, because the way dub is distributed are not by using a git repository.

@Geod24
Copy link
Member

Geod24 commented Dec 29, 2023

The obvious workaround is to use repository dependencies instead of submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants