-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new standards #144
Comments
@wickedOne For the first one, could you try the following with <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
<properties>
<property name="allowFullyQualifiedGlobalClasses" value="true"/>
<property name="allowFullyQualifiedGlobalConstants" value="true"/>
<property name="allowFullyQualifiedGlobalFunctions" value="true"/>
<property name="searchAnnotations" type="boolean" value="true"/>
</properties>
</rule> |
i'm not entirely sure what would be the purpose of trying another coding standard within this one; |
@wickedOne I'd use it as a dependency, see https://github.com/djoos/Symfony-coding-standard/pull/183/files#diff-ab8597c76d04ad91201fc5cb1ea17cad514970360d740fe3d4bf016cdc88e70d for how it would look like to use slevomat sniffs instead of some homegrown ones in this standard. For testing the snippet above, you'd need to add it to your setup in some way (composer and auto-registration with https://github.com/DealerDirect/phpcodesniffer-composer-installer is what I use in such cases) and add the code in |
did a quick compare between current sniffs and symfony's current standards and noticed the following new rules (which i'll try to provide a sniff for next weekend):
Structure:
Documentation
for the last one i think we at most can throw a warning
The text was updated successfully, but these errors were encountered: