Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code with "black" #17

Open
jedie opened this issue Jan 21, 2019 · 3 comments
Open

Reformat code with "black" #17

jedie opened this issue Jan 21, 2019 · 3 comments

Comments

@jedie
Copy link
Contributor

jedie commented Jan 21, 2019

I use "black" for all my codes... Think it would be good to reformat the code here, too.

@maerteijn
Copy link
Member

I was thinking about at least a flake8 linter with import order. "black" is nice but not something the whole community agrees on (as pyflakes and pycodestyle).

@jedie
Copy link
Contributor Author

jedie commented Jan 22, 2019

I think "black" is very good. Just because you can't control anything except the line length.
So there are no "variants" of the format.

@maerteijn maerteijn changed the title reformat code with "black" Reformat code with "black" Feb 1, 2019
@maerteijn
Copy link
Member

I did some basic formatting and applied it already, see the configuration here: https://github.com/django-oscar/django-oscar-docdata/blob/master/setup.cfg#L4

Works still needs to be done so I leave this issue open, to be continued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants