Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of increment_blocks. #65

Open
benmurden opened this issue Mar 24, 2019 · 1 comment
Open

Purpose of increment_blocks. #65

benmurden opened this issue Mar 24, 2019 · 1 comment

Comments

@benmurden
Copy link

def increment_blocks(self):
self.total_blocks += 1
self.save()

There is no total_blocks property on this model, so are inheriting classes meant to implement it, or is this old code that can be removed?

@solarissmoke
Copy link
Member

It looks like it was never properly implemented (see 76d5931) and has always been broken. Looks like record_blocked_request isn't used anywhere either so the simplest path at this stage is just to remove this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants